-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(editor): separate requirements checks #6596
Conversation
return result.newProjectContents ?? projectContents | ||
} | ||
|
||
function createStoryboardFileIfNecessaryInner( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from here to the end of the file it is just code that was moved from actions.tsx
(no logic change)
#14956 Bundle Size — 58.03MiB (~+0.01%).7b16857(current) vs d1d46c1 master#14949(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #14956 |
Baseline #14949 |
|
---|---|---|
Initial JS | 41.01MiB (~+0.01% ) |
41.01MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 18.06% |
18.18% |
Chunks | 20 |
20 |
Assets | 22 |
22 |
Modules | 4163 (+0.1% ) |
4159 |
Duplicate Modules | 213 |
213 |
Duplicate Code | 27.31% (-0.04% ) |
27.32% |
Packages | 477 |
477 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #14956 |
Baseline #14949 |
|
---|---|---|
JS | 58.02MiB (~+0.01% ) |
58.02MiB |
HTML | 7.37KiB (-0.25% ) |
7.39KiB |
Bundle analysis report Branch refactor/requirements Project dashboard
Generated by RelativeCI Documentation Report issue
This PR is mainly a refactor one, separating requirements check so it will be easy to add more.
actions.tsx
to its own file (no logic change)Manual Tests:
I hereby swear that: