Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do Not Insert In Progress Insertion #6593

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanparsons
Copy link
Contributor

Problem:
When an insertion was in progress but not complete, tabbing away from the editor would result in a zero-sized element being inserted.

Cause:
The editor onBlur handler was clearing the interaction session, but applying any inflight changes which caused the element to be inserted.

Fix:
Now the interaction session is cancelled without applying changes and the editor mode is reset to select mode.

Commit Details:

  • resetStateOnBlur now clears the interaction session without applying changes and resets the editor mode to select mode.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

- `resetStateOnBlur` now clears the interaction session without applying changes
  and resets the editor mode to select mode.
Copy link
Contributor

github-actions bot commented Oct 25, 2024

Try me

Copy link

relativeci bot commented Oct 25, 2024

#14938 Bundle Size — 57.98MiB (~+0.01%).

8d0124c(current) vs 916e8b9 master#14936(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#14938
     Baseline
#14936
Regression  Initial JS 40.97MiB(~+0.01%) 40.97MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18% 0%
No change  Chunks 20 20
No change  Assets 22 22
No change  Modules 4152 4152
No change  Duplicate Modules 213 213
No change  Duplicate Code 27.33% 27.33%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14938
     Baseline
#14936
Regression  JS 57.98MiB (~+0.01%) 57.98MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch fix/do-not-insert-when-tabbing-a...Project dashboard


Generated by RelativeCIDocumentationReport issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant