Do Not Insert In Progress Insertion #6593
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When an insertion was in progress but not complete, tabbing away from the editor would result in a zero-sized element being inserted.
Cause:
The editor onBlur handler was clearing the interaction session, but applying any inflight changes which caused the element to be inserted.
Fix:
Now the interaction session is cancelled without applying changes and the editor mode is reset to select mode.
Commit Details:
resetStateOnBlur
now clears the interaction session without applying changes and resets the editor mode to select mode.Manual Tests:
I hereby swear that: