New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(editor): remove duplicate UID check #6418

Draft

liady wants to merge 1 commit into master from chore/remove-uid-check

Contributor

liady commented Sep 26, 2024 •

edited

Loading

The WIP PR removed all of the duplicate UID code and checks

Manual Tests:
I hereby swear that:

I opened a hydrogen project and it loaded
I could navigate to various routes in Preview mode

Fixes #5654


          chore(editor): remove duplicate UID check

6ba0633

Contributor

github-actions bot commented Sep 26, 2024 •

edited

Loading

Try me

relativeci bot commented Sep 26, 2024

#14411 Bundle Size — 62.59MiB (-0.14%).

6ba0633(current) vs 916e8b9 master#14360(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics

Change

5 changes

Improvement

2 improvements

	Current #14411	Baseline #14360
Initial JS	`45.77MiB`(`-0.05%`)	`45.8MiB`
Initial CSS	`0B`	`0B`
Cache Invalidation	`28.8%`	`22.37%`
Chunks	`30`	`30`
Assets	`33`	`33`
Modules	`4382`(`-0.07%`)	`4385`
Duplicate Modules	`517`(`-0.58%`)	`520`
Duplicate Code	`31.56%`(`-0.19%`)	`31.62%`
Packages	`472`	`472`
Duplicate Packages	`70`	`70`

Bundle size by type

Change

2 changes

Improvement

2 improvements

	Current #14411	Baseline #14360
JS	`62.58MiB` (`-0.14%`)	`62.66MiB`
HTML	`11.12KiB` (`-0.32%`)	`11.16KiB`

Bundle analysis report Branch chore/remove-uid-check Project dashboard

^{Generated by RelativeCI Documentation Report issue}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet