Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It barely scrubs #6195

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

It barely scrubs #6195

wants to merge 1 commit into from

Conversation

maltenuhn
Copy link
Member

@maltenuhn maltenuhn commented Aug 7, 2024

Problem:
Draft PR for pointerLock scrubbing

However, I'm opening this PR to check the approach since scrubbing slows down, and grinds to a halt after a few frames, even w/ console closed.

slothscrub

Not addressed:

  • actual rendering of simulated pointer (incl offsets)
  • wrapping of that pointer around the screen (!) - one of the original intentions behind this
  • handling global pointerLockChange and pointerLockError events
  • any other cleaning of the original code (eg we don't use vertical handling anywhere

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Try me

Copy link

relativeci bot commented Aug 7, 2024

#13707 Bundle Size — 62.67MiB (~+0.01%).

7439750(current) vs 6339ece master#13706(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13707
     Baseline
#13706
Regression  Initial JS 45.76MiB(~+0.01%) 45.76MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.66% 21.64%
No change  Chunks 30 30
No change  Assets 33 33
No change  Modules 4380 4380
No change  Duplicate Modules 524 524
No change  Duplicate Code 31.61% 31.61%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13707
     Baseline
#13706
Regression  JS 62.66MiB (~+0.01%) 62.66MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch scrubberyProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant