Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced Grid Settings Popup #6191

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Advanced Grid Settings Popup #6191

wants to merge 8 commits into from

Conversation

lankaukk
Copy link
Collaborator

@lankaukk lankaukk commented Aug 6, 2024

Feature PR to review here: #6354

Creating an "Advanced Grid Settings" popup that can be opened from the grid inspector section dropdown.
Also adjusting the options for the layout system section dropdowns, and their UX copy.

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented Aug 6, 2024

Try me

Copy link

relativeci bot commented Aug 6, 2024

#13890 Bundle Size — 62.49MiB (-0.01%).

fbbdad5(current) vs 6339ece master#13857(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Improvement 1 improvement
                 Current
#13890
     Baseline
#13857
Improvement  Initial JS 45.62MiB(-0.01%) 45.63MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.17% 21.52%
No change  Chunks 30 30
No change  Assets 33 33
Change  Modules 4374(-0.02%) 4375
No change  Duplicate Modules 519 519
No change  Duplicate Code 31.64% 31.64%
No change  Packages 472 472
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Improvement 2 improvements
                 Current
#13890
     Baseline
#13857
Improvement  JS 62.48MiB (-0.01%) 62.49MiB
Improvement  HTML 11.05KiB (-0.33%) 11.09KiB

Bundle analysis reportBranch advanced-modal-sampleProject dashboard


Generated by RelativeCIDocumentationReport issue

@bkrmendy bkrmendy mentioned this pull request Aug 27, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants