-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced Grid Settings Popup #6191
Draft
lankaukk
wants to merge
8
commits into
master
Choose a base branch
from
advanced-modal-sample
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#13890 Bundle Size — 62.49MiB (-0.01%).fbbdad5(current) vs 6339ece master#13857(baseline) Warning Bundle contains 70 duplicate packages – View duplicate packages Bundle metrics
|
Current #13890 |
Baseline #13857 |
|
---|---|---|
Initial JS | 45.62MiB (-0.01% ) |
45.63MiB |
Initial CSS | 0B |
0B |
Cache Invalidation | 22.17% |
21.52% |
Chunks | 30 |
30 |
Assets | 33 |
33 |
Modules | 4374 (-0.02% ) |
4375 |
Duplicate Modules | 519 |
519 |
Duplicate Code | 31.64% |
31.64% |
Packages | 472 |
472 |
Duplicate Packages | 70 |
70 |
Bundle size by type 2 changes
2 improvements
Current #13890 |
Baseline #13857 |
|
---|---|---|
JS | 62.48MiB (-0.01% ) |
62.49MiB |
HTML | 11.05KiB (-0.33% ) |
11.09KiB |
Bundle analysis report Branch advanced-modal-sample Project dashboard
Generated by RelativeCI Documentation Report issue
…to advanced-modal-sample
…to advanced-modal-sample
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature PR to review here: #6354
Creating an "Advanced Grid Settings" popup that can be opened from the grid inspector section dropdown.
Also adjusting the options for the layout system section dropdowns, and their UX copy.
Manual Tests:
I hereby swear that:
Fixes #[ticket_number] (<< pls delete this line if it's not relevant)