Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: locking with data attribute #6139

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

gbalint
Copy link
Contributor

@gbalint gbalint commented Jul 29, 2024

Problem:
Describe the problem being addressed as succinctly as possible.

Fix:
Describe the fix you have made as succinctly as possible.

Commit Details: (< vv pls delete this section if's not relevant)

  • Renamed thing to otherThing
  • Removed cake from fridge-contents.ts
  • Did [other things]

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

Copy link
Contributor

github-actions bot commented Jul 29, 2024

Try me

Copy link

relativeci bot commented Jul 29, 2024

#13578 Bundle Size — 62.66MiB (~+0.01%).

b6c5471(current) vs 6339ece master#13577(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 2 changes Regression 1 regression
                 Current
#13578
     Baseline
#13577
Regression  Initial JS 45.73MiB(~+0.01%) 45.73MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 21.58% 28.1%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4377 4377
No change  Duplicate Modules 525 525
No change  Duplicate Code 31.64% 31.64%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13578
     Baseline
#13577
Regression  JS 62.65MiB (~+0.01%) 62.64MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch spike/lock-data-attrProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant