Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component Menu Picker with Radix #6078

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jul 15, 2024

TODO

  • separator component
  • fix tests
  • figure out hover bug

Out of scope for this PR (to be implemented in follow-up PRs)

  • Use a dropdown in place of the context menu in other places as well (can be tracked by where useCreateCallbackToShowComponentPicker is used)

@bkrmendy bkrmendy changed the title Component Menu PIcker with Radix Component Menu Picker with Radix Jul 15, 2024
Copy link
Contributor

github-actions bot commented Jul 15, 2024

Try me

Copy link

relativeci bot commented Jul 15, 2024

#13564 Bundle Size — 62.66MiB (+0.02%).

ea426aa(current) vs 6339ece master#13563(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#13564
     Baseline
#13563
Regression  Initial JS 45.74MiB(+0.03%) 45.72MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 28.4% 21.55%
No change  Chunks 31 31
No change  Assets 34 34
No change  Modules 4380 4380
No change  Duplicate Modules 525 525
Change  Duplicate Code 31.63%(-0.03%) 31.64%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13564
     Baseline
#13563
Regression  JS 62.65MiB (+0.02%) 62.64MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feature/positioned-component-pic...Project dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant