Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Update Modal #6000

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from
Draft

Data Update Modal #6000

wants to merge 16 commits into from

Conversation

bkrmendy
Copy link
Contributor

@bkrmendy bkrmendy commented Jun 19, 2024

Description

Update the Shopify CMS from Utopia

Manual Tests

I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Preview mode

Fixes #[ticket_number] (<< pls delete this line if it's not relevant)

@bkrmendy bkrmendy changed the title wip Data Update Modal Jun 19, 2024
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Try me

Copy link

relativeci bot commented Jun 19, 2024

#13394 Bundle Size — 62.66MiB (+0.02%).

5bf07f0(current) vs 6339ece master#13386(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#13394
     Baseline
#13386
Regression  Initial JS 45.74MiB(+0.03%) 45.72MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 22.46% 21.55%
No change  Chunks 31 31
No change  Assets 34 34
Change  Modules 4372(+0.02%) 4371
No change  Duplicate Modules 521 521
No change  Duplicate Code 31.68% 31.68%
No change  Packages 469 469
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#13394
     Baseline
#13386
Regression  JS 62.65MiB (+0.02%) 62.64MiB
Improvement  HTML 11.16KiB (-0.33%) 11.2KiB

Bundle analysis reportBranch feature/data-update-modalProject dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants