Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(editor): separate requirements checks #6596

Merged
merged 5 commits into from
Oct 29, 2024
Merged

Conversation

liady
Copy link
Contributor

@liady liady commented Oct 29, 2024

This PR is mainly a refactor one, separating requirements check so it will be easy to add more.

  • move every requirement check to its own file (no logic change, just separating them)
  • move the storyboard check and creation from actions.tsx to its own file (no logic change)
  • add tests for checks
  • (small) use semver for React check

Manual Tests:
I hereby swear that:

  • I opened a hydrogen project and it loaded
  • I could navigate to various routes in Play mode

return result.newProjectContents ?? projectContents
}

function createStoryboardFileIfNecessaryInner(
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from here to the end of the file it is just code that was moved from actions.tsx (no logic change)

Copy link
Contributor

github-actions bot commented Oct 29, 2024

Try me

Copy link

relativeci bot commented Oct 29, 2024

#14956 Bundle Size — 58.03MiB (~+0.01%).

7b16857(current) vs d1d46c1 master#14949(baseline)

Warning

Bundle contains 70 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression
                 Current
#14956
     Baseline
#14949
Regression  Initial JS 41.01MiB(~+0.01%) 41.01MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 18.06% 18.18%
No change  Chunks 20 20
No change  Assets 22 22
Change  Modules 4163(+0.1%) 4159
No change  Duplicate Modules 213 213
Change  Duplicate Code 27.31%(-0.04%) 27.32%
No change  Packages 477 477
No change  Duplicate Packages 70 70
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#14956
     Baseline
#14949
Regression  JS 58.02MiB (~+0.01%) 58.02MiB
Improvement  HTML 7.37KiB (-0.25%) 7.39KiB

Bundle analysis reportBranch refactor/requirementsProject dashboard


Generated by RelativeCIDocumentationReport issue

@liady liady marked this pull request as ready for review October 29, 2024 14:58
@liady liady changed the title refactor(editor): separate requirements check refactor(editor): separate requirements checks Oct 29, 2024
@liady liady merged commit 2ff7ab6 into master Oct 29, 2024
13 checks passed
@liady liady deleted the refactor/requirements branch October 29, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants