Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paginate over compare runs endpoint #21

Merged
merged 3 commits into from
Nov 6, 2023
Merged

paginate over compare runs endpoint #21

merged 3 commits into from
Nov 6, 2023

Conversation

austin3dickey
Copy link
Member

Corresponding to conbench/conbench#1527.

@austin3dickey
Copy link
Member Author

Got this locally (probably will see it once the build completes too):

❯ checking for portable file names ... NOTE
  Found the following non-portable file path:
    conbenchcoms/tests/testthat/resp-class/localhost/api/compare/benchmark-results/10aded...0af-81f373.json
  
  Tarballs are only required to store paths of up to 100 bytes and cannot
  store those of more than 256 bytes, with restrictions including to 100
  bytes for the final component.
  See section ‘Package structure’ in the ‘Writing R Extensions’ manual.

Any suggestions for reconciling this with how the mocking package works?

@boshek
Copy link
Collaborator

boshek commented Nov 6, 2023

Thanks for this!

@boshek boshek merged commit 84c2f70 into main Nov 6, 2023
5 checks passed
@austin3dickey austin3dickey deleted the aus/paginate3 branch November 6, 2023 20:31
assignUser pushed a commit to ursacomputing/crossbow that referenced this pull request Nov 9, 2023
conbench/conbenchcoms#21 make some changes to
the R conbench client. This PR updates that and some other dependencies.
In addition, this update some of the reporting code to be inline with
that conbenchcoms code.

fyi @assignUser and @raulcd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants