Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom attributes must be protected #123

Open
uilianries opened this issue Oct 31, 2019 · 0 comments · May be fixed by #124
Open

Custom attributes must be protected #123

uilianries opened this issue Oct 31, 2019 · 0 comments · May be fixed by #124

Comments

@uilianries
Copy link
Member

As discussed in the past, only ConanFile attributes (e.g. topics, options, settings, ...) should be public. Custom attributes (e.g. _build_subfolder, _source_subfolder) must be declared as protect to avoid any possible future conflict.
uilianries added a commit to uilianries/hooks that referenced this issue Nov 1, 2019
@uilianries
conan-io#123 Custom attributes must be protected
935e847 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries linked a pull request Nov 1, 2019 that will close this issue
Open
uilianries added a commit to uilianries/hooks that referenced this issue Nov 1, 2019
@uilianries
conan-io#123 Update KB number to 35
754b2ef 
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries mentioned this issue Nov 1, 2019
Open
uilianries added a commit to uilianries/hooks that referenced this issue Nov 1, 2019
@uilianries
conan-io#123 Dont accept private members
e96ab92 
Signed-off-by: Uilian Ries <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#123 Custom attributes must be protected uilianries/hooks
1 participant
@uilianries