Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Buildroot feature example #74

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Jan 20, 2021

It's an example from Conan Community, now archive.

https://github.com/conan-community/buildroot

I'm going to update the documentation too.

This PR is large because Buildroot distributes one file for each package + scripts needed for building. As it generates an embedded Linux image and need to build bootloader, kernel and rootfs, it takes 2h to build everything. Thus, I excluded it from CI job.

The only thing which should be considered to be reviewed is README.md

If you want to know how does it work, read https://docs.conan.io/en/latest/integrations/cross_platform/buildroot.html

Requires #76 first

@uilianries uilianries marked this pull request as draft January 20, 2021 13:38
Signed-off-by: Uilian Ries <[email protected]>
@uilianries uilianries marked this pull request as ready for review January 20, 2021 13:43
Signed-off-by: Uilian Ries <[email protected]>
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say that embedding those many files we don't really produce here, should be avoided. Isn't it possible to get those files with a git clone, a download + unzip from elsewhere? It would be enough to document it

@uilianries
Copy link
Member Author

Good idea, yes, we can download and apply our changes.

Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
Signed-off-by: Uilian Ries <[email protected]>
@uilianries
Copy link
Member Author

@memsharded I reduced buildroot example, it's much much less than before.

conan_config file is a recipe which tells to Buildroot what should be built or not. It's not mandatory, it's a configuration file. Without it the user would need run make menuconfig and mark all Conan flags. Not hard, just operational.

The diff comes from Conan Community, but updated with latest Conan version (1.33) and packages. As it's not a git folder, I used diff -ruN to extract the patch file.

Still, we can't run it on CI, because buildroot build ALL from sources, bootloader, kernel, packages, ... just like Yocto, it takes hours.

features/buildroot/run.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants