Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cycloneDX as a Conan tool and implement subgraph for conanfile #17559

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

ErniGH
Copy link
Contributor

@ErniGH ErniGH commented Jan 10, 2025

Changelog: Feature: Add cycloneDX as a Conan tool and implement subgraph for conanfile
Docs: conan-io/docs#3959

Closes #16173

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely better architecture, less risky, more extensible, looking good

conan/tools/sbom/cycloneDX.py Outdated Show resolved Hide resolved
test/functional/sbom/test_cycloneDX.py Outdated Show resolved Hide resolved
conan/tools/sbom/cycloneDX.py Outdated Show resolved Hide resolved
test/functional/sbom/test_cycloneDX.py Outdated Show resolved Hide resolved
test/functional/sbom/test_cycloneDX.py Outdated Show resolved Hide resolved
test/functional/sbom/test_cycloneDX.py Outdated Show resolved Hide resolved
conan/tools/sbom/cyclonedx.py Show resolved Hide resolved
@memsharded memsharded added this to the 2.12.0 milestone Jan 23, 2025
subgraph_hook = textwrap.dedent("""\
import os, json
from conan.tools.files import save
from conan.internal.model.lockfile import Lockfile
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's not document this until we make it public API (no need to change anything here)

@memsharded memsharded merged commit e130969 into conan-io:develop2 Jan 23, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make feasible for recipes to get a serialized subgraph of the current node
2 participants