Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extra patches path #17520

Draft
wants to merge 1 commit into
base: develop2
Choose a base branch
from

Conversation

memsharded
Copy link
Member

Changelog: Feature: Allow applying patches on "create" time for conan-center-index like layouts from an external centralized folder.
Docs: https://github.com/conan-io/docs/pull/XXXX

Close #17360

Some constraints:

  • Recipes must have export_conandata_patches() call
  • Recipes must have the conandata.yml with a patches entry (otherwise export_conandata_patches fails anyway)
  • It only works after a trim_conandata(). If not it will most likely crash.

@memsharded memsharded added this to the 2.12.0 milestone Dec 23, 2024
@kambala-decapitator
Copy link
Contributor

just tested this with my patch from conan-io/conan-center-index#26260 - worked great!

at first I tried to pass the new config value on command line, but got

ERROR: [conf] 'core.*' configurations are not allowed in profiles.

is it intended that this feature is global and not per-profile?

And I didn't see the new message Applying extra patches 'core.sources.patch:extra_path', although expected to. The command I used was conan install --require minizip/1.3.1 ...


_handle_patches(conanfile_patches, conanfile.recipe_folder)

# NOTE: This only works after drim_conandata, it assumes versions are gone now in the cache
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# NOTE: This only works after drim_conandata, it assumes versions are gone now in the cache
# NOTE: This only works after trim_conandata, it assumes versions are gone now in the cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] consider ability to apply/inject arbitrary patches to recipe without forking repository
2 participants