Use FFI to perform paycall multi-step simulation #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
banky
commented
Nov 8, 2024
|
|
||
| libs = ["./lib"] | ||
|
|
||
| [profile.ir] | ||
| via_ir = true | ||
| optimizer = true | ||
| optimizer = false |
There was a problem hiding this comment.
This should not go into main, just using locally to make the compiler a bit faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the logic for multi-step simulation for paycall transactions is all done on the client side. This PR aims to move this logic into QuarkBuilder by making a call to a simulation ffi. ie. when calling the builder with an intent which uses paycall, the builder first simulates the transaction to get the estimated max payment cost and then uses the estimate for building up the transaction with paycall