Store combining class in a static byte array #47
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to #41, introducing a static byte array for combining classes. There are no changes in other areas, so
NormalizeStream
still queries this array twice (both forisCombining
check and forgetCombiningClass
), but, surprisingly, performance became better in several cases.Ideally, we would unify this array to cover
isDecomposable
property as well (represented as combining class 255, see Section 14.1.3), but since there are two ways to decompose (NFD and NFKD), such change would involve quite a lot of restructuring, which I do not have time to dive into right now, unfortunately.