Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge To Orig #186

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Merge To Orig #186

wants to merge 3 commits into from

Conversation

xjasg
Copy link

@xjasg xjasg commented Oct 22, 2024

No description provided.

@@ -128,7 +128,7 @@ public List<ProxiSpectrum> Retrieve()
//injection time
if (ionInjectionTime != null)
{
proxiSpectrum.AddAttribute(accession: "MS:1000927", name: "ion injection time",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xjasg Can you update your branch? Some of the terms on your side are outdated; we fixed them in our previous release.

Copy link
Collaborator

@caetera caetera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request seems to be made against version 1.4.2
Please, make a PR against the latest code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants