Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cmake] Support non-standalone builds #347

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

aaronj0
Copy link
Collaborator

@aaronj0 aaronj0 commented Oct 29, 2024

Fixes bugs in the CMake when built with ROOT, providing the right settings for clang and LLVM options and paths

Fixes bugs in the CMake when built with ROOT, providing the right settings for clang and LLVM options and paths
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@444495e). Learn more about missing BASE report.
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #347   +/-   ##
=======================================
  Coverage        ?   74.43%           
=======================================
  Files           ?        8           
  Lines           ?     3204           
  Branches        ?        0           
=======================================
  Hits            ?     2385           
  Misses          ?      819           
  Partials        ?        0           

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aaronj0 aaronj0 merged commit b2d787b into compiler-research:main Oct 29, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants