Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes some variables in CppInterOpconfig.cmake.in file #336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anutosh491
Copy link
Contributor

This was discovered while building xeus-cpp . We have the following in xeus-cpp

find_package(CppInterOp ${CppInterOp_REQUIRED_VERSION} REQUIRED)
if(CppInterOp_FOUND)
  message(STATUS "Found CppInterOp: config=${CPPINTEROP_CONFIG} dir=${CPPINTEROP_DIR} (found version=${CPPINTEROP_VERSION} compatible with Clang ${CPPINTEROP_LLVM_VERSION_MAJOR}.x)")
endif()

which ends up being

Found CppInterOp: config= dir= (found version= compatible with Clang 19.x)

So CPPINTEROP_CONFIG , CPPINTEROP_DIR, CPPINTEROP_VERSION are empty but CPPINTEROP_LLVM_VERSION_MAJOR has "19.x"

After this we could have

message(STATUS "Found CppInterOp: config=${CPPINTEROP_CMAKE_DIR} dir=${CPPINTEROP_INSTALL_PREFIX} (found version=${CPPINTEROP_LLVM_PACKAGE_VERSION} compatible with Clang ${CPPINTEROP_LLVM_VERSION_MAJOR}.x)")

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.45%. Comparing base (826be78) to head (c06715c).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #336   +/-   ##
=======================================
  Coverage   74.45%   74.45%           
=======================================
  Files           8        8           
  Lines        3206     3206           
=======================================
  Hits         2387     2387           
  Misses        819      819           

@anutosh491
Copy link
Contributor Author

Gentle ping. I think this should be ready. Pretty small change. Can be seen while building xeus-cpp that cmake dir is not set correctly. This PR fixes that

-- Found compatible xeus version: 5.1.1
-- CPPINTEROP_CONFIG: /Users/anutosh491/micromamba/envs/xeus-cpp/lib/cmake/cppinterop
-- CPPINTEROP_CMAKE_DIR: 
-- CPPINTEROP_LIBRARIES: /Users/anutosh491/micromamba/envs/xeus-cpp/lib/libclangCppInterOp.dylib
-- CPPINTEROP_DIR: /Users/anutosh491/micromamba/envs/xeus-cpp
-- CPPINTEROP_VERSION: 1.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant