Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Script: zoneminder #1662

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

New Script: zoneminder #1662

wants to merge 20 commits into from
+161 −0

Conversation

connorjfarrell
Copy link

✍️ Description

Create ZoneMinder CT script

creates ubuntu 22.04 CT w/ mariadb+zoneminder (installed via apt ref. PPA repo). Based on: https://zoneminder.readthedocs.io/en/stable/installationguide/ubuntu.html#ubuntu-22-04-jammy

✅ Prerequisites

The following steps must be completed for the pull request to be considered:

  • Self-review performed (I have reviewed my code to ensure it follows established patterns and conventions.)
  • Testing performed (I have thoroughly tested my changes and verified expected functionality.)

🛠️ Type of Change

Please check the relevant options:

  • [] Bug fix (non-breaking change that resolves an issue)
  • [] New feature (non-breaking change that adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to change unexpectedly)
  • New script (a fully functional and thoroughly tested script or set of scripts)

📋 Additional Information (optional)

Provide any extra context or screenshots about the feature or fix here.

@github-actions github-actions bot added new script A change that adds a new script website A change to the website labels Jan 22, 2025
@connorjfarrell connorjfarrell marked this pull request as ready for review January 22, 2025 04:58
@connorjfarrell connorjfarrell requested a review from a team as a code owner January 22, 2025 04:58
@michelroegl-brunner
Copy link
Member

Why an old ubuntu? debian 12 is supported wich is our default.

@MickLesk
Copy link
Member

And why so many Missing informations, and old Comments from Dev Guide?

@michelroegl-brunner michelroegl-brunner changed the title Connorjfarrell/zoneminder New Script: zoneminder Jan 22, 2025
@connorjfarrell
Copy link
Author

@michelroegl-brunner

Why an old ubuntu? debian 12 is supported wich is our default.

Ubuntu vs Debian - debian install/update process less straightforward to stay up to date w/ latest ZM releases.
Old version - misread ZM docs when I started creating, can try w/ 24.04 and validate still builds.

@MickLesk

And why so many Missing informations, and old Comments from Dev Guide?

What information am I missing (other than the header metadata which should now be updated)? By old comments, are you referencing the comments on lines 8-24 of zoneminder.sh?

@michelroegl-brunner
Copy link
Member

He means all the comments you have in there remove them.

Also please shorten all messages in msg_info and msg_ok. max 4 words per. Also during update, remove some of the messges, they are to much.
also remove the backup you created during update. backups have to be done by the user.

@connorjfarrell
Copy link
Author

Removed comments, shorted msg_info+msg_ok messages, removed messages during update, removed backup from update function

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new script A change that adds a new script website A change to the website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjfarrell @michelroegl-brunner @MickLesk