Fix #190 Add splitDrive, takeDrive, dropDrive and isDrive #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI is failing because it is out of date. I will add a commit to update the CI to this pull request. |
NorfairKing
reviewed
Oct 17, 2023
Comment on lines
+384
to
+385
| -- | Split an absolute path into a drive and, perhaps, a path. On POSIX, @/@ is | ||
| -- a drive. |
There was a problem hiding this comment.
On POSIX, @/@ is a drive.
Is it a good idea to have these functions defined for non-windows?
We could put it in the windows-specific code I guess, but I don't have an opinion yet about whether that's a good idea.
There was a problem hiding this comment.
Non-well typed equivalent functions exist for both POSIX and WINDOWS at filepath package: System.FilePath. I think it is sensible to prove well-typed equivalents. I followed that package's Haddock documentation for this package.
NorfairKing
approved these changes
Oct 17, 2023
|
@mpilgrem Ok, I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds related tests in test-suite
test.Also adds related tests in test-suite
validity-test, butvalidity-test(generally, before this change) hangs when run on my Windows 11 machine (so I could not test the tests), and I note thatvalidity-testis excluded from the existing CI.Also adds an entry in the Change Log and bumps the package version.