Add shipments type to ResourceLineItem component
#445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
malessani
reviewed
Nov 27, 2023
pfferrari
force-pushed
the
add-shipment-resourcelistitem
branch
from
09e67a2 to
53a4f10
Compare
gciotola
reviewed
Nov 27, 2023
Comment on lines
+5
to
+10
| export interface ShipmentDisplayStatus extends DisplayStatus { | ||
| label: string | ||
| icon: IconProps['name'] | ||
| color: IconProps['background'] | ||
| task?: string | ||
| } |
There was a problem hiding this comment.
Probably there is no need to re-define the props since you are extending them from DisplayStatus
There was a problem hiding this comment.
Right note.. I'd like to share the same question to you all because we made the same thing for all other dictionaries.. We should review them all..
gciotola
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
shipmentstype toResourceLineItemcomponent.shipments.stock_transfersrelationship.Checklist