Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing useEffect for ResourceAddress internal state #441

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Add missing useEffect for ResourceAddress internal state #441

merged 1 commit into from
Nov 24, 2023
+5 −1

Conversation

pfferrari
Copy link
Contributor

What I did

I added a useEffect hook to update address internal state of ResourceAddress component every time component resource prop value is changed.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests).
  • Make sure to add/update documentation regarding your changes.
  • You are NOT deprecating/removing a feature.

@pfferrari pfferrari added the bug Something isn't working label Nov 24, 2023
@pfferrari pfferrari self-assigned this Nov 24, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 24, 2023 •
edited
Loading

✅ Deploy Preview for commercelayer-app-elements ready!

Name Link
🔨 Latest commit 815f26b
🔍 Latest deploy log https://app.netlify.com/sites/commercelayer-app-elements/deploys/65607d604d550e00082c67f7
😎 Deploy Preview https://deploy-preview-441--commercelayer-app-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pfferrari pfferrari changed the title Add missing useEffect for ResourceAddress resource state Add missing useEffect for ResourceAddress internal state Nov 24, 2023
@pfferrari pfferrari merged commit 34eb104 into main Nov 24, 2023
4 checks passed
@pfferrari pfferrari deleted the reactive-resource-address branch November 24, 2023 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gciotola gciotola gciotola approved these changes

@marcomontalbano marcomontalbano Awaiting requested review from marcomontalbano

Assignees

@pfferrari pfferrari

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pfferrari @gciotola