Add stock_transfers type in ResourceListItem component
#423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for commercelayer-app-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
pfferrari
changed the title
stock_transfers type in ResourceListItems componentstock_transfers type in ResourceListItem component
gciotola
reviewed
Nov 9, 2023
There was a problem hiding this comment.
shall we keep those file names snakeCase or 1:1 as the resource name?
There was a problem hiding this comment.
I would use the camelCase notation: stockTransfers.tsx
There was a problem hiding this comment.
Sure! I just renamed both the dictionary and transformer file! :)
gciotola
approved these changes
Nov 9, 2023
malessani
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I added
stock_transfersrelated dictionary file and enabledResourceListItemto render resources of kindstock_transfers.I also updated the rendering of resources of kind
returnsto match updated design.Checklist