ford - reset steering angle state when driver stops overriding steering #2064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfeiferj
force-pushed
the
steering-pressed-angle-reset
branch
from
7afa5a2
to
53d5fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if the driver manually steers faster than the angle rate limits for Ford (and others) then openpilot will not be able to resume from the current curvature/steering angle until the rate limit catches up to the actual state.
This resets the steering angle with the previous measured angle upon detecting the user has stopped overriding. This means that rate limit clips will be centered on the currently measured angle for the first frame after done overriding.