CANParser: Initialize value dicts directly from DBC Msg #1381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the initialization process of CANParser by directly initializing value dicts from the DBC
Msgstruct in the constructor. This eliminates the previous reliance on callingsef.update_strings([])to perform this initialization.These changes streamline the initialization flow and clarify the logic, It also resolves issue #913, where update_strings([]) returned the latest state when passed an empty list. A new test case,
test_parser_empty_list(), has been added to verify that this issue is fixed and to ensure proper behavior when an empty list is used.This PR also lays the groundwork for resolving two related issues: #1068 and #1066. With this update, addressing these issues will become simpler and more efficient.