-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace custom components with @material/web #14
Conversation
Welcome to new-connect! Make sure to:
deployed preview: https://14.connect-d5y.pages.dev |
This is in a working state but I'm getting type errors in VS Code for the custom web components, https://github.com/SgLy/material-web-solid-js-typing is very new |
"consider SolidUI which is a port of https://github.com/shadcn-ui/ui for solid." I'm a bigger fan of this alternative route. It seems like going with other UI libraries people end up changing the components or there ends up being a lot of components not being used (80/20 principle). Building our own component library would give the UI a better experience since we can tweak components and build a better native like experience. We can still pick and choose what things we want to adopt from other UI libraries and create them in our own, like what you did for some components that were based on Material 3. Would be cool to see new-connect experiment and do things differently than how old connect went about UI |
I agree we should do something different from old connect, but that was using MUI react components and not web components, however... @material/web looked promising but since it won't be updated to add missing components soon, may as well use shadcn-ui/SolidUI |
@material/web is a collection of web components based on the Material 3 design system
The components I created (in
src/components/material
) were based on Material 3, but the @material/web package wasn't ready at the time. They haven't implemented every component yet, but we can use some (and align with its theming system to make adopting it easier).tailwind.config.js
for our custom components)TODO
Alternatives