Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoverage buildinfo #647

Merged
merged 2 commits into from
Jul 4, 2019
Merged

Scoverage buildinfo #647

merged 2 commits into from
Jul 4, 2019

Conversation

nvander1
Copy link
Contributor

@nvander1 nvander1 commented Jul 3, 2019

Fixes #640. @lefou

@krcz your idea about taking generatedSources from outer was correct. I also had to modify the xmlReport and htmlReport to pass allSources instead of just sources to the report builder so it can instrument the generated source files.

This should also fix any other tools that generate source files as part of the mill build.

Copy link
Member

@lefou lefou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for the fix.

@lefou lefou merged commit 0a7d687 into com-lihaoyi:master Jul 4, 2019
@lefou lefou added this to the after-0.4.2 milestone Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scoverage: Issue when also using BuildInfoModule
2 participants