Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notes to BULK_MANAGER.md to make removeBulkAction and addBulkAction more obvious #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asecondwill
Copy link

@asecondwill asecondwill commented Jan 9, 2024

Description

I got muddled up yesterday trying to specify the classname to add and remove actions. Obvious once you know.

Here I am fumbling around on SO.
https://stackoverflow.com/questions/77781532/adding-and-removing-actions-from-silverstripe-bulkmanager/77786065#77786065

So some notes here to help others (me in a few months)

Manual testing steps

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

Add notes on adding and removing actions as it wasn't obvious for me on first look.
@GuySartorelli
Copy link
Collaborator

Hi there,

Thank you for your contribution.
I notice that you didn't follow the pull request template - I've added that template back in to your pull request description. Please fill in all of the relevant information and follow the documented contribution guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants