-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[channel-picker] Add support for the compact
prop
#169
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for color-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd make the text smaller. And maybe the space bold? But also, I’m thinking there is value in keeping the |
All the text or only the channels?
I agree. How about a |
I worked with the component a bit more, tweaked the styles a bit, and added support for the https://deploy-preview-169--color-elements.netlify.app/src/channel-picker/ |
Better but it still doesn't communicate hierarchy — the channel picker is much more prominent than its color space :/ I wonder if there's any prior art, how does software with a colorspace / channel selector communicate the hierarchy? PS: Remember that you need more horizontal padding than vertical padding for them to optically look the same |
What if we use I couldn't find any examples of software that allows one to choose a specific channel in a specified color space. 🤷♂️ |
This is huge :( Think of how it would look in the components we want to use it… |
I should have said that I made it bigger for demo purposes. It's not the size it will have IRL; it's just an illustration of the idea. I switched back to 100% font size in the Codepen. |
No I got that. But you usually want something having a height of about one line. Think of any of these above a chart for exmaple. |
a3dcdcb
to
f4aa696
Compare
I quite like the second one! It has the right horizontal format, and conveys hierarchy better than any of the other options. Not sure we need the gradient, we can just make them both the same border color (make sure it works with dark mode too) |
f4aa696
to
faa78ad
Compare
<select>
compact
prop
@LeaVerou, I implemented the style with connectors. Could you please take a look? |
f20d0a3
to
8e13753
Compare
17d2aad
to
0bf925e
Compare
…he picker Plus, some style tweaks
0bf925e
to
2f68190
Compare
Following our discussion with @LeaVerou on Messenger, this PR is an experiment using radio buttons to select a channel instead of a
<select>
element.Works in dark mode, too:
I wonder what you think about it.
Live preview: https://deploy-preview-169--color-elements.netlify.app/src/channel-picker/
Here is what it looks like inside charts: https://deploy-preview-169--color-elements.netlify.app/src/color-chart/