Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[color-chart] Add support for the info prop #116

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

DmitrySharabin
Copy link
Member

@DmitrySharabin DmitrySharabin commented Oct 10, 2024

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for color-elements ready!

Name Link
🔨 Latest commit d411d66
🔍 Latest deploy log https://app.netlify.com/sites/color-elements/deploys/6707f14b2773c60008a8b075
😎 Deploy Preview https://deploy-preview-116--color-elements.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

DmitrySharabin added a commit to color-js/palettes that referenced this pull request Oct 10, 2024
Available after this PR is merged: color-js/elements#116
@DmitrySharabin DmitrySharabin changed the title [color-chart] Add support for the info property [color-chart] Add support for the info prop Oct 10, 2024
@@ -39,6 +39,20 @@ You can also specify a whole label, and if it contains a number, the number will

_(Colors courtesy of Tailwind)_

### The `info` attribute

You can use the `info` attribute to show information about the color scale points. Currently, the only type of information supported is color coords (in any color space), but more will be added in the future.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we also support deltaE?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's in progress. We are iterating over it. Probably, it's high time to resume that iteration. 🙂

@DmitrySharabin DmitrySharabin merged commit 524e924 into main Oct 10, 2024
4 checks passed
@DmitrySharabin DmitrySharabin deleted the info-prop branch October 10, 2024 16:09
DmitrySharabin added a commit to color-js/palettes that referenced this pull request Oct 10, 2024
* Make two `<select>`s connected _for real_

* Update chart color data points info on space change by adopting the updated API (color-js/elements#116)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants