-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement restapi services to handle authentication flow #39
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tested these endpoints together with the code on the main
branch of volto-authomatic
and it works perfectly.
I would somehow merge the documentation on DEVELOP.md and the existing on README.md regarding the configuration of KeyCloak.
I don't know if the best thing is to add this documentation in README and DEVELOP or perhaps add a new sphinx-based docs folder and deploy it to RTD.
@erral Is this good enough to be merged? |
@ericof in general everything looks ok to me too. this afternoon I have some time to do a second check and give a second opinion as well. thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of comments. Otherwise absolutely awesome for me.
|
||
You need a working `python` environment (system, `virtualenv`, `pyenv`, etc) version 3.8 or superior. | ||
|
||
Then install the dependencies and a development instance using: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not (yet) generally using pip. For me make install
was not enough, I also had to do:
python3.11 -m venv .
bin/pip install cookiecutter mxdev -c contraints.txt
Have I made a mistake or forgotten something?
Ok. |
@mamico Please, also invite the collective user |
@mamico Just confirming: users |
Fixes #38