Allow overriding label for values #37
Conversation
src/collective/volto/formsupport/restapi/services/submit_form/field.py
Outdated
Show resolved
Hide resolved
src/collective/volto/formsupport/restapi/services/submit_form/post.py
Outdated
Show resolved
Hide resolved
Pull Request Test Coverage Report for Build 7920161992Details
💛 - Coveralls |
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py
|
While getting this up-to-date, I noticed we are now removing fields who's IDs don't exist on the form block definition (great!). This logic needs updating to account for custom_field_id being sent rather than the original field ID |
# Conflicts: # src/collective/volto/formsupport/tests/test_send_action_form.py
|
@JeffersonBledsoe Add some tests please |
Ah ok, exists already, just opened old version of this pr in some way :D |
Haha, thanks for checking! 😄 I look forward to the feedback! |
# Conflicts: # src/collective/volto/formsupport/restapi/services/submit_form/post.py # src/collective/volto/formsupport/tests/test_send_action_form.py
|
@JeffersonBledsoe thanks! looks good and useful for me, I will test them with a staging environment and come back shortly. Just a question, if you already know, the changes here are useless, but also non-breaking, if you have the current Volto addon, is that right? So, if I understand correctly, the dependency will be to have this released first and the frontend later? |
This PR introduces the concept of a 'display value' to change how a value will appear in an email or on a form. For example, a 'Single choice' field could have submitted values of
['A', 'B', 'C'], but are shown to the user as['Option A', 'Value B', 'Option C'].Mostly tested in production with the 'Yes/ No widget' in volto-form-block, but should work for other fields too!
Requires collective/volto-form-block#85 for frontend