Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve migration from pfg #445

Closed
wants to merge 4 commits into from
Closed

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Jan 13, 2025

No description provided.

ThibautBorn and others added 3 commits January 13, 2025 16:26
context: prevent keyerror when viewing data in easyform
context: list values  were added on 1 line in text widgets, which breaks some functionality
also don't ignore list default values
@gotcha gotcha force-pushed the gotcha/improve-migration-from-pfg branch from 8035ea8 to 01a7b10 Compare January 13, 2025 15:26
@gotcha gotcha requested review from ale-rt and thet January 13, 2025 15:33
Copy link
Member

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions. I did not do a test run to check the changes.

src/collective/easyform/migration/actions.py Outdated Show resolved Hide resolved
src/collective/easyform/migration/actions.py Show resolved Hide resolved
@gotcha
Copy link
Member Author

gotcha commented Jan 16, 2025

Merger manually

@gotcha gotcha closed this Jan 16, 2025
@gotcha gotcha deleted the gotcha/improve-migration-from-pfg branch January 16, 2025 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants