feat(chain) add variable to specify chain #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minorOffense
changed the title
…x into firewallchain
minorOffense
pushed a commit
that referenced
this pull request
Sep 21, 2023
Added details to host network interface for SNMP Added details to host network interface for SNMP Added spec acceptance test for interfacetype and interfacedetails Added context test3.example.com to acceptance test Fix include in test3 context Fix hash syntax in test3 context Change template for snmp in acceptance test Fix case for var template_snmp Removed conflicts on templates used for snmp host test acceptance Trying to fix interface details data types Sub double quote with single quote in include Trying to understand if interface details is nil Fix trailing whitespace :-O! Zabbix version 4.0 doesn't have the interface details hash, excluded from test Wip (#1) * Added details to result_hosts * Add TODO file * Run test specific to zabbix >= 4.0 * Add param documentation * Fix spaces * Remove TODO file Fix suggested
minorOffense
pushed a commit
that referenced
this pull request
Sep 21, 2023
rebase on current master
Set for agent only right now
Avoid -A in chain See puppetlabs/puppetlabs-firewall#1170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Add the capacity to specify which firewall chain to add the rules to
This Pull Request (PR) fixes the following issues
voxpupuli#604