Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: e2e tests #77

Merged
merged 15 commits into from
Jan 15, 2025
Merged

feat: e2e tests #77

merged 15 commits into from
Jan 15, 2025

Conversation

stat
Copy link
Contributor

@stat stat commented Jan 14, 2025

What changed? Why?

  • adding e2e tests

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Jan 14, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

John-peterson-coinbase
John-peterson-coinbase reviewed Jan 14, 2025
View reviewed changes
Copy link
Contributor

@John-peterson-coinbase John-peterson-coinbase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a GHA to run the e2e tests on PRs similar to the unit tests.

Makefile Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
@stat stat force-pushed the christopher.gerber/feat/tests-e2e branch from e9f734f to 038fcc5 Compare January 14, 2025 19:34
@stat stat marked this pull request as ready for review January 14, 2025 20:37
John-peterson-coinbase
John-peterson-coinbase reviewed Jan 14, 2025
View reviewed changes
.github/workflows/e2e_tests.yml Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
tests/test_e2e.py Outdated Show resolved Hide resolved
@stat stat force-pushed the christopher.gerber/feat/tests-e2e branch from 5e292cf to 2368eed Compare January 14, 2025 23:33
@stat stat merged commit aabbdad into master Jan 15, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@John-peterson-coinbase John-peterson-coinbase John-peterson-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stat @cb-heimdall @John-peterson-coinbase