Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make delete a instance method #75

Merged
merged 13 commits into from
Jan 11, 2025
Merged

make delete a instance method #75

merged 13 commits into from
Jan 11, 2025

Conversation

howard-at-cb
Copy link
Contributor

@howard-at-cb howard-at-cb commented Jan 11, 2025

What changed? Why?

make python SDK's webhook deletion behave the same as node and ruby SDK, it will be a instance method without needing clients to enter a webhook ID.

 wh1 = next(gen1)
CDP API REQUEST: GET https://api.cdp.coinbase.com/platform/v1/webhooks?limit=100
CDP API RESPONSE: Status: 200, Data: b'{"data":[{"created_at":"2024-12-13T20:24:39.256Z","event_type":"smart_contract_event_activity","event_type_filter":{"contract_addresses":["0xa0b86991c6218b36c1d19d4a2e9eb0ce3606eb48"]},"id":"675c980709b4be439a116ade","network_id":"ethereum-mainnet","notification_uri":"https://webhook.site/57cb34a7-51aa-4ba8-b0a5-b435bebf99a5","updated_at":"2024-12-16T21:47:29.07Z"}],"has_more":false}\n'
>>> wh1.delete_webhook()
CDP API REQUEST: DELETE https://api.cdp.coinbase.com/platform/v1/webhooks/675c980709b4be439a116ade
CDP API RESPONSE: Status: 200, Data: b''

Qualified Impact

cb-davidlai
cb-davidlai previously approved these changes Jan 11, 2025
jazz-cb
jazz-cb previously approved these changes Jan 11, 2025
@howard-at-cb howard-at-cb dismissed stale reviews from jazz-cb and cb-davidlai via 9c3ea28 January 11, 2025 02:19
@cb-heimdall
Copy link

cb-heimdall commented Jan 11, 2025

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@howard-at-cb howard-at-cb merged commit bd1a8f3 into v0.14.0 Jan 11, 2025
7 checks passed
@howard-at-cb howard-at-cb deleted the modify-delete-webhook branch January 11, 2025 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants