Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Allow wallet.save_seed to create a file if necessary #4

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[chore] Allow wallet.save_seed to create a file if necessary #4

merged 1 commit into from
Sep 24, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

  • Allow wallet.save_seed("seeds.json") to create a new file if one doesn't already exist.

@cb-heimdall
Copy link

cb-heimdall commented Sep 24, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-allow-save-seed-create-new-file branch from 4dbc2b7 to 049a8d1 Compare September 24, 2024 17:47
@John-peterson-coinbase John-peterson-coinbase force-pushed the chore-allow-save-seed-create-new-file branch from 049a8d1 to 1333f39 Compare September 24, 2024 21:01
@John-peterson-coinbase John-peterson-coinbase merged commit df2f0cd into master Sep 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase