Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PSDK-500] Contract Invocation Support #13

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[PSDK-500] Contract Invocation Support #13

merged 2 commits into from
Sep 30, 2024

Conversation

John-peterson-coinbase
Copy link
Contributor

What changed? Why?

  • Contract invocation support via wallet.invoke_contract(...)

Qualified Impact

@cb-heimdall
Copy link

cb-heimdall commented Sep 29, 2024 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@John-peterson-coinbase John-peterson-coinbase force-pushed the psdk-500-contract-invocation branch 2 times, most recently from 26774c8 to 4786f45 Compare September 29, 2024 23:20
rohan-agarwal-coinbase
rohan-agarwal-coinbase reviewed Sep 30, 2024
View reviewed changes
cdp/wallet.py
ValueError: If the default address does not exist.

"""
if self.default_address is None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

slight different but in the typescript SDK we error if there is no default_address in the defaultAddress() function so this if check is not needed across all the functions. should we do that same pattern here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's reasonable. I will take a pass through in a follow-up and key all of these off the can sign property.

cdp/wallet_address.py Outdated
ContractInvocation: The contract invocation object.

"""
normalied_amount = Decimal(amount) if amount else Decimal("0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: normalied_amount > normalized_amount

@cb-heimdall
Copy link

Review Error for rohan-agarwal-coinbase @ 2024-09-30 15:05:23 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@cb-heimdall
Copy link

Review Error for rohan-agarwal-coinbase @ 2024-09-30 15:09:39 UTC
User failed mfa authentication, public email is not set on your github profile. see go/mfa-help

@John-peterson-coinbase John-peterson-coinbase merged commit d0fc1c3 into master Sep 30, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohan-agarwal-coinbase rohan-agarwal-coinbase rohan-agarwal-coinbase approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@John-peterson-coinbase @cb-heimdall @rohan-agarwal-coinbase