Add Main Paymaster Example Components #495
Conversation
cpcramer
force-pushed
the
paul/add-paymaster-main-components
branch
2 times, most recently
from
85dfebd to
4050d09
Compare
| '<rootDir>/app/api/paymasterProxy', | ||
| '<rootDir>/app/paymaster-bundler/utils/', |
There was a problem hiding this comment.
These are so specific because some unrelated tests are failing which will need to be fixed. Once the tests are fixed I can update this to be <rootDir>/app/
There was a problem hiding this comment.
Interesting..... if that's the case also open a public issue on Github so we don't forget to fix it.
There was a problem hiding this comment.
Tracking here #496
| import { baseSepolia } from 'viem/chains'; | ||
|
|
||
| const paymasterService = process.env.NEXT_PUBLIC_PAYMASTER_URL ?? ''; |
There was a problem hiding this comment.
This was originally in the constants.ts file. I figured that it wasn't necessary to assign a const to the env variable when I can just access the env whenever I needed it.
It looked like:
const PAYMASTER_SERVICE_URL = process.env.NEXT_PUBLIC_PAYMASTER_URL
| chainId, | ||
| entrypoint, | ||
| userOp, | ||
| }: { |
There was a problem hiding this comment.
Types are easier to read when are more explicit as their own variable.
like
type dude = { ... }
and than you use dude
There was a problem hiding this comment.
Updated to look like:
type ChainId = number;
type Entrypoint = string;
type UserOp = UserOperation<'v0.6'>;
type WillSponsorParams = {
}: {
chainId: ChainId;
entrypoint: Entrypoint;
userOp: UserOp;
};
export const willSponsor = async ({
chainId,
entrypoint,
userOp,
}: WillSponsorParams)
| if (calldata.functionName !== 'executeBatch') return false; | ||
| if (!calldata.args || calldata.args.length == 0) return false; | ||
|
|
||
| const calls = calldata.args[0] as { |
There was a problem hiding this comment.
Each type should have his own variable.
There was a problem hiding this comment.
Updated to:
type CallDataTargetAddress = Address;
type CallDataValue = bigint;
type CallData = Hex;
const calls = calldata.args[0] as {
target: CallDataTargetAddress;
value: CallDataValue;
data: CallData;
}
| * Checks if the call data in the user operation is valid and meets sponsorship criteria. | ||
| * | ||
| */ | ||
| function isValidCallData(userOp: UserOperation<'v0.6'>): boolean { |
There was a problem hiding this comment.
UserOperation<'v0.6'> what's this?
There was a problem hiding this comment.
I know this looks weird but it's a type that UserOperation extends called EntryPointVersion...there is a type error if this is omitted.
There was a problem hiding this comment.
From the documentation - export type EntryPointVersion = "v0.6" | "v0.7"
|
|
||
| /** | ||
| * Checks if the call data in the user operation is valid and meets sponsorship criteria. | ||
| * |
There was a problem hiding this comment.
I don't follow, should I add more to the function comment?
There was a problem hiding this comment.
Wait - Updated to remove the empty * line
template/web/app/paymaster-bundler/_components/PaymasterBundlerDemo.tsx
Outdated
Show resolved
Hide resolved
template/web/app/paymaster-bundler/_components/PaymasterBundlerDemo.tsx
Outdated
Show resolved
Hide resolved
cpcramer
changed the title
cpcramer
force-pushed
the
paul/add-paymaster-main-components
branch
3 times, most recently
from
7e7c9b6 to
8fd3286
Compare
cpcramer
force-pushed
the
paul/add-paymaster-main-components
branch
from
8fd3286 to
44826a9
Compare
| import { ENTRYPOINT_ADDRESS_V06 } from 'permissionless'; | ||
| import { paymasterActionsEip7677 } from 'permissionless/experimental'; | ||
| import { createClient, http } from 'viem'; | ||
| import { createPublicClient } from 'viem'; |
There was a problem hiding this comment.
why two lines to import from viem, just do one line.
What changed? Why?
Notes to reviewers
How has it been tested?