-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Mint NFT Stepper #327
Conversation
import SwitchNetwork from './SwitchNetwork'; | ||
|
||
const EXPECTED_CHAIN = baseSepolia; | ||
export const EXPECTED_CHAIN = baseSepolia; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should have some sort of config file for this.
Or even better question, should this information come from the Hook that was generated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added as constant for now. We can refactor to hook in follow up PR.
return <MintProcessingStep />; | ||
} | ||
|
||
if (mintStep === MintSteps.OUT_OF_GAS_STEP) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting, I am starting seeing some common steps happening between contracts.
Something to reflect on in future PRs, on how to abstract this in a simple reusable way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or is it even worth abstract? I guess more open question in general.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good question, and something I was thinking a lot about. I decided against abstracting them even though there is similarity due to the fact that we may have complex logic in these steps at some point that are specific to the particular action (Mint, Buy Coffee, etc.). If we continue to see overlap it may be worth abstracting in a future PR.
template/src/pageComponents/mint/steps/MintCompleteStep/MintCompleteStep.tsx
Outdated
Show resolved
Hide resolved
import { SymbolIcon } from '@radix-ui/react-icons'; | ||
import clsx from 'clsx'; | ||
|
||
export default function MintProcessingStep() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see we create this Issue for later #328, which is great.
I was thinking if we should also find a way to consolidate or abstract how states work in a contract. So it's easier for a developer re-build them.
template/src/pageComponents/mint/steps/OutOfGasStep/OutOfGasStep.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LFG
What changed? Why?
Screenshots
Start Mint NFT
Mint Processing
Out Of Gas
Mint Complete
How has it been tested?