-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-components): Implements CadTreeView for nodes in a Cad model #4854
Open
nilscognite
wants to merge
24
commits into
master
Choose a base branch
from
np/tree-again
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description 📝
How has this been tested? 🔍
This PR is based on code from C. Tannum. It integrates loading of the nodes in a tree from CDF.
CadTreeView
: Is the react componentCadTreeProps
: According properiesTreeView
is showRoot. This is true by default.In
CadTreeProps
I have removed the properties ofTreeProps
that is no meaning. Also I have addedonLoaded
.onLoaded
is called when node is loaded, but before is is added/inserted into the tree. Here you can set the defaultCheckBoxState
and other initialization. Typically:Some unitlity functions I have made:
forceNodeInTree()
: Force a specific node in the tree. Use case was given by C. Tannum.scrollToTreeIndex() and scrollToNode()
: Utility function for scrollingTest instructions ℹ️
I don't know how to test this in React-comp. Test it in Fusion directly?
Checklist ☑️