-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Image360Details component #3589
Conversation
…tedata/reveal into christjt/image-360-wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few comments related to design.
react-components/src/components/Image360Details/Image360Details.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/Image360Details/Image360Details.tsx
Outdated
Show resolved
Hide resolved
…tedata/reveal into christjt/image-360-wrapper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but still minor design things to fix.
react-components/src/components/Image360Details/Image360Details.tsx
Outdated
Show resolved
Hide resolved
react-components/src/components/Image360Details/Image360Details.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 🤌
Type of change
Description 📝
Adds a wrapper around Image360HistoricalDetails that levarages the useReveal hook and adds some of the boilerplate needed for the current solution. Also adds an exit button.
Test instructions ℹ️
Image360 story has been updated to use this new
Checklist ☑️