Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't export toolbar buttons directly #3527

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

haakonflatval-cognite
Copy link
Contributor

Type of change

Feat

Jira ticket 📘

https://cognitedata.atlassian.net/browse/

Description 📝

Export toolbar buttons only as toolbar properties, e.g. RevealToolbar.SlicerButton instead of just SlicerButton.

How has this been tested? 🔍

Test instructions ℹ️

Checklist ☑️

  • I am proud of this feature.
  • I have performed a self-review of my own code.
  • I have added PR type (Feat, Bug, Chore, Test, Docs, Style, Refactor) to the PR title.
  • I have manually tested this for different scenarios (different models, formats, devices, browsers).
  • I have commented my code in hard-to-understand areas.
  • I have made corresponding changes to the public documentation.
  • I have added unit and visuals tests to prove that my feature works to the best of my ability.
  • I have refactored the code for readability to the best of my ability.
  • I have checked that my changes do not introduce regressions in the public documentation.
  • I have outlined any known defects / lacking capabilities in the contents of this PR.
  • I have listed any remaining work that should follow this PR in the description or jira/miro/etc.
  • I have added TSDoc to any public facing changes.
  • I have added "developer documentation" in any package README.md that is related / applicable to this PR.
  • I have noted down and am currently tracking any technical debt introduced in this PR.
  • I have thoroughly thought about the architecture of this implementation.
  • I have asked peers to test this feature.

@haakonflatval-cognite haakonflatval-cognite added the slack PRs and issues with this label will be pushed to Slack label Jul 31, 2023
@haakonflatval-cognite haakonflatval-cognite requested a review from a team as a code owner July 31, 2023 08:18
@christjt christjt changed the title breaking: don't export toolbar buttons directly fix: don't export toolbar buttons directly Jul 31, 2023
@haakonflatval-cognite haakonflatval-cognite enabled auto-merge (squash) July 31, 2023 09:30
@haakonflatval-cognite haakonflatval-cognite added the auto-update Makes bulldozer automatically update this PR when there are changes to the target branch label Jul 31, 2023
@haakonflatval-cognite haakonflatval-cognite merged commit ec83f85 into master Jul 31, 2023
13 checks passed
@haakonflatval-cognite haakonflatval-cognite deleted the hflatval/dont-export-buttons-directly branch July 31, 2023 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-update Makes bulldozer automatically update this PR when there are changes to the target branch slack PRs and issues with this label will be pushed to Slack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants