Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to reconnect #727

Merged
merged 4 commits into from
Oct 30, 2024
Merged

Some improvements to reconnect #727

merged 4 commits into from
Oct 30, 2024

Conversation

einarmo
Copy link
Collaborator

@einarmo einarmo commented Oct 30, 2024

There is an issue here, this may help, not sure if this is actually the cause of anything major though.

There is an issue here, this may help, not sure if this is actually the
cause of anything major though.
Copy link

codecov bot commented Oct 30, 2024

Codecov Report

Attention: Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.03%. Comparing base (c9b04a9) to head (1f455aa).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
Extractor/SessionManager.cs 88.88% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #727      +/-   ##
==========================================
- Coverage   82.16%   80.03%   -2.14%     
==========================================
  Files         125      125              
  Lines       18156    18185      +29     
  Branches     2713     2716       +3     
==========================================
- Hits        14918    14554     -364     
- Misses       2401     2820     +419     
+ Partials      837      811      -26     
Files with missing lines Coverage Δ
Extractor/SessionManager.cs 78.68% <88.88%> (+1.67%) ⬆️

... and 7 files with indirect coverage changes

@einarmo einarmo merged commit 8668c64 into master Oct 30, 2024
8 of 9 checks passed
@einarmo einarmo deleted the reconnect-improvements branch October 30, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants