Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to transform filter to use a list of values #663

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

einarmo
Copy link
Collaborator

@einarmo einarmo commented Jun 20, 2024

List can either be included directly in config, or read from a local file.

This PR also (mostly) removes the browse-callback functionality, which hasn't worked for years, so nobody can possibly be using it.

List can either be included directly in config, or read from a local
file.
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 91.03139% with 20 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (2554fba) to head (6ba0786).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #663   +/-   ##
=======================================
  Coverage   82.85%   82.85%           
=======================================
  Files         123      123           
  Lines       17696    17763   +67     
  Branches     2648     2657    +9     
=======================================
+ Hits        14662    14718   +56     
- Misses       2224     2236   +12     
+ Partials      810      809    -1     
Files Coverage Δ
Extractor/UAExtractor.cs 78.98% <100.00%> (-0.03%) ⬇️
Extractor/NodeTransformation.cs 77.68% <0.00%> (-8.86%) ⬇️
ExtractorLauncher/Program.cs 83.69% <75.00%> (-0.40%) ⬇️
Extractor/Config/ExtractionConfig.cs 91.87% <91.42%> (-1.29%) ⬇️

... and 9 files with indirect coverage changes

@einarmo einarmo merged commit a055ece into master Jun 24, 2024
9 checks passed
@einarmo einarmo deleted the filter-from-list branch August 20, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants