Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a few more pieces of missing metadata #479

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Conversation

einarmo
Copy link
Collaborator

@einarmo einarmo commented Aug 30, 2023

No description provided.

@einarmo einarmo requested a review from a team as a code owner August 30, 2023 11:03
@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #479 (6913d11) into master (0175254) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #479      +/-   ##
==========================================
- Coverage   83.86%   83.81%   -0.05%     
==========================================
  Files         108      108              
  Lines       16452    16470      +18     
  Branches     2491     2491              
==========================================
+ Hits        13798    13805       +7     
- Misses       1908     1919      +11     
  Partials      746      746              
Files Changed Coverage Δ
Extractor/Nodes/UAReferenceType.cs 100.00% <100.00%> (ø)
Extractor/Pushers/FDM/BaseDataModelDefinitions.cs 100.00% <100.00%> (ø)
Extractor/Pushers/FDM/InstanceBuilder.cs 80.53% <100.00%> (+0.09%) ⬆️
Extractor/Pushers/FDM/TypeMetadata.cs 100.00% <100.00%> (ø)
Extractor/Pushers/FDM/Types/NodeTypes.cs 96.15% <100.00%> (+0.07%) ⬆️

... and 2 files with indirect coverage changes

Copy link
Contributor

@ozangoktan ozangoktan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@einarmo einarmo merged commit 3c48611 into master Sep 1, 2023
3 checks passed
@einarmo einarmo deleted the add-missing-metadata branch April 17, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants