Avoid changing root-ness of assets

cognitedata · Sep 9, 2024 · 66313a0 · 66313a0
1 parent 11df628
commit 66313a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/Extractor/Pushers/PusherUtils.cs b/Extractor/Pushers/PusherUtils.cs
@@ -181,11 +181,11 @@ private static bool ShouldSetNewMetadata(FullConfig config, Dictionary<string, s
             if (update.Context && !newAsset.ParentId.IsNullNodeId)
             {
                 var parentId = extractor.GetUniqueId(newAsset.ParentId);
-                if (parentId != old.ParentExternalId)
+                // Do not move an asset from root to non-root or the other way around.
+                if (parentId is null == old.ParentExternalId is null
+                    && parentId != old.ParentExternalId)
                 {
-#pragma warning disable CS8604 // Possible null reference argument.
-                    assetUpdate.ParentExternalId = new UpdateNullable<string>(parentId);
-#pragma warning restore CS8604 // Possible null reference argument.
+                    assetUpdate.ParentExternalId = new UpdateNullable<string?>(parentId);
                 }
             }
 

diff --git a/manifest.yml b/manifest.yml
@@ -73,6 +73,7 @@ versions:
       fixed:
         - Avoid unnecessarily repeating pushes of timeseries and references.
         - Improve logging when the upload queue is full.
+        - Do not update whether or not an asset is a root node.
   "2.30.3":
     description: Fix various issues.
     changelog: