Make metadata same accross roles #760
Open
+293
−1,811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
doctrino
reviewed
Nov 19, 2024
| @@ -37,6 +38,7 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| @pytest.mark.skip(reason="Skipping this test until refactoring of rules is completed") | |||
There was a problem hiding this comment.
Does this mean that we are in a non-releaseable state?
There was a problem hiding this comment.
Temporary file. Should not be committed. Suggest adding something like ~*.xlsx to .gitignore.
doctrino
reviewed
Nov 19, 2024
| @@ -125,6 +150,34 @@ class BaseMetadata(SchemaModel): | |||
| """ | |||
|
|
|||
| role: ClassVar[RoleTypes] | |||
| aspect: ClassVar[DataModelAspect] | |||
| space: SpaceType = Field(SchemaCompleteness.partial, alias="prefix") | |||
|
|
||
| @abstractmethod | ||
| def get_prefix(self) -> str: |
There was a problem hiding this comment.
Lets remove this and replace it with .prefix. It is only used in one location
| Unlike namespace, the identifier does not end with "/" or "#". | ||
| """ | ||
| return DEFAULT_NAMESPACE[f"data-model/verified/{self.aspect}/{self.space}/{self.external_id}/{self.version}"] |
There was a problem hiding this comment.
I like this! Very good idea to have aspect as part of the unique identifier.
| license: str | None = None | ||
| rights: str | None = None | ||
| physical: str | None = None | ||
| conceptual: str | None = None |
There was a problem hiding this comment.
Is the thinking here to use these two fields to link the different input rules?
| metadata["namespace"] = default | ||
| def fix_space(metadata: dict, default: str = "neat") -> dict: | ||
| if space := metadata.get("space", None): | ||
| if not isinstance(space, str) or not PATTERNS.space_compliance.match(space): |
There was a problem hiding this comment.
A consequence now is that Information rules needs to use a prefix that is compliant with the regex for CDF space?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namespacenow automatically generated not anymore settable