-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
attempting to add headers and add test #797
Conversation
This reverts commit 543ba9d.
): F[Seq[Header]] = | ||
sttpRequest | ||
.headers(headers: _*) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that headers from sttpRequest would be preserved if not present in argument, it makes sense by default for things like x-cdp-app, x-cdp-sdk etc, for .acceptEncoding we can still override it with headers, but if main motivation is only acceptEncoding then maybe add dedicated parameter for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I can use "overrideHeaders" but that was my intention here. Just being a bit more general.
I tried various approaches to test this feature, including:
In the end I gave up, but not before trying to see if the headers were correctly overriden using https://www.postman.com/postman/published-postman-templates/documentation/ae2ja6x/postman-echo?ctx=documentation and they are so this should be working right... but not sure how to test it properly without refactor